When to take the combat skill.

Based on experience, it's best to take it right away, but if there's an opportunity to learn, it's better to learn 1 rank for gold, as it saves you 2 levels. However, there's an exception: if you don't like the combo class of your faction and you want to level up a hero with a combo class without fighting, then you should skip the battle to avoid hindering that class.