If you take the same number of troops, then the Dark Elves are definitely the best. They have the highest quality troops!
El Feroz, I completely agree that the best faction is the one you play best!
However, I absolutely disagree that Dark Elves are weak when attacking a castle. In my opinion, quite the opposite - only a fool would hide from them behind walls. They can take down anyone with area-of-effect spells. IMO, they don't even need a Phoenix. I prefer to upgrade something else instead of summoning one. They need to be fought in melee combat, exploiting their weak defense.