As for Champions and Death Knights, everything has already been said, and it was said correctly.
The hero's luck only affects the probability of dealing double damage and does not affect the chance of a Death Knight dealing a double hit – it is 20%.
New here? I'm Roha — want a quick tour?